Fix system df to count content blobs and deduplicate shared storage#1555
Open
realrajaryan wants to merge 1 commit into
Open
Fix system df to count content blobs and deduplicate shared storage#1555realrajaryan wants to merge 1 commit into
realrajaryan wants to merge 1 commit into
Conversation
realrajaryan
force-pushed
the
fix/system-df-disk-usage
branch
from
1dca65d to
c00c1cf
Compare
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
container system dfomits image content blobs from image size and reclaimable bytes #1526 and [Bug]:container system dfdouble-counts image storage when the same image has multiple tags #1527.Type of Change
Motivation and Context
This PR fixes
system dfto report actual on-disk allocated bytes (content blobs + snapshots) instead of summing per-image snapshot sizes. Orphaned blobs are now included as reclaimable, and storage shared across tags is no longer double counted. Also consolidates three identicalcalculateDirectorySizeimplementations into a sharedFileManager.allocatedSize(of:)extension.Testing